Template talk:Protected

Final review -- Pyrrhus (talk) 17:36, October 1, 2019 (EDT)

User:Notjusttired please review the minor changes I made to this template. Before doing so, however, please review the updated "interface explanations" for the various messages to better understand which message is used when. Once this template is finalized, it should be fully protected since it is called by interface messages. Thanks for creating this useful template!
Pyrrhus (talk) 17:36, October 1, 2019 (EDT)

This looks good, although demospace should really be added since this affects the layout and options available, options are "other" (eg for interface messages), article, file (different layout), Category and template. | demospace ={{{demospace|other}}} would set it to "other" while allowing a default value to be passed in.

Protection is also needed for Module:Message box, and these file names can be left out if "demospace" is set (I just need to update the default filenames first, I think in Module:Message box/configuration. Is it intentional to have the default black lock without a border? ~Njt (talk) 20:02, October 1, 2019 (EDT) Also - translations can be done later, we may want to add an option to change the text for this? Eg | text={{{talk|xxxxx}}} where the xxxxxx is our existing message. ~Njt (talk) 20:08, October 1, 2019 (EDT)

Good points, Njt. I'm gonna break out the bullet points to respond:

• • • Go ahead and add the demospace, I don't fully understand demospace yet.
    • I haven't even thought about protection for the module namespace. Do we want the entire Module namespace to be semi-protected? Which module pages require full protection?
    • I don't know when the default black lock message would be used, so I left it without a border, in case we want to use it for a message that already comes with its own outline.
    • For translations, bear in mind that the pre-existing interface message comes with translations that may be good enough for now.

Pyrrhus (talk) 20:46, October 1, 2019 (EDT)

Ideally all modules and templates should be semi-protected, although you may want to check that first with JaimeS. I do edit modules or copy over new ones fairly often. There's many links to Wikipedia categories or file names we don't have - and they don't appear in "What links to".

For this particular page, having looked into it some more, the module is total overkill and does very little - it's really not necessary to call Lua just to create a table with an image and message in it! Having read more of the module, Demospace is not used except when mbox is called (we use ombox and fmbox instead). Just documented that.

Either this template could be changed to use fmbox instead, or the Fmbox code (or something similar) could be used here. Both quick and easy. Would rather get it in and working for now though. So many tasks and features here come from over the top, complex code - including the original protection templates. Translations - I guess we can use the default, possibly adding a padlock image. ~Njt (talk) 21:30, October 1, 2019 (EDT)

Sounds good Njt. A couple questions:

• • • • • 1) The next round of developer requests will make both "Template" and "Module" namespaces semi-protected by default. Which "Module" pages might need to be fully protected, if any?

The citation ones come to mind. ~Njt (talk) 23:07, October 1, 2019 (EDT)

• • • • • 2) Why don't we use mbox in this template? Wouldn't mbox just default to fmbox since this template is only used in interface messages?

Mbox relies on the module, and again it's complex and overkill when all we need is a table, with text and image. The module has a lot of debugging, error categories etc. Read the module and compare to Template:Fmbox to see what I mean. ~Njt (talk) 23:07, October 1, 2019 (EDT)

• • • • • 3) If we want to hard-code fmbox, shouldn't we hard-code fmbox for all the options in this template, since this template is only used in interface messages?

Certainly an option if want to start that off. First check by a search for other modules using Fmbox, plus the What links here for templates. Modules are written in Lua which is pretty readable, but they frequently call other modules and may be used by many templates and it can be hard to work out exactly what is going on. Some do tracking categories as well. ~Njt (talk) 23:07, October 1, 2019 (EDT)

• • • • • Thanks1 Pyrrhus (talk) 21:53, October 1, 2019 (EDT)

I just had the idea that perhaps adding a category inside "noinclude" would be a good idea - ie semi-protected pages and fully protected pages categories. That would be easier than going through the protection log and nothing to maintain.

When replying, if you can use colons or something other than stars to reply - stars get indented much more so I end up with less than half the screen width to reply. Collapsing earlier chat and starting a new reply on the far left is fine to spot when not many talking (ad I have just done). Thanks. ~Njt (talk) 23:07, October 1, 2019 (EDT)

Thanks for the helpful info! I tried using fmbox throughout the template, and it certainly seems to look the same in testing. Sorry about the indentation!

Pyrrhus (talk) 00:45, October 2, 2019 (EDT)

Dark skin compatibility

User:Pyrrhus Please change the following code, which should mean that the Timeless dark skin shows the gold, silver and red padlocks as transparent rather than with a white background. (Note that a black padlock should not have a transparent background). Thanks ~Njt (talk) 09:54, October 27, 2019 (EDT)

 Done

Pyrrhus (talk) 13:23, October 27, 2019 (EDT)

Old code:

|image=[[File:Semi-protection-shackle.svg|x20px|link=MEpedia:PROTECT|alt=Semi-protection grey padlock]]

New code:

|image=[[File:Semi-protection-shackle.svg|x20px|link=MEpedia:PROTECT|alt=Semi-protection silver padlock|class=transparent]]

Old code:

|image=[[File:Full-protection-shackle.svg|x20px|link=MEpedia:PROTECT|alt=Full protection gold padlock]]

New code:

|image=[[File:Full-protection-shackle.svg|x20px|link=MEpedia:PROTECT|alt=Full protection gold padlock|class=transparent]]

Old code:

|image=[[File:Red-protection-padlock.svg|x20px|link=MEpedia:PROTECT|alt=Interface red protection padlock]]

New code:

|image=[[File:Red-protection-padlock.svg|x20px|link=MEpedia:PROTECT|alt=Interface red protection padlock|class=transparent]]